This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1816: Date format Stellar function #1233
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ | |
import java.util.Calendar; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
import java.util.TimeZone; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertTrue; | ||
|
@@ -225,4 +226,36 @@ public void testDayOfYearNow() { | |
public void testDayOfYearNull() { | ||
Object result = run("DAY_OF_YEAR(nada)"); | ||
} | ||
|
||
@Test | ||
public void testDateFormat() { | ||
Object result = run("DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzz', epoch, 'EST')"); | ||
assertEquals("Thu Aug 25 2016 08:27:10 EST", result); | ||
} | ||
|
||
@Test | ||
public void testDateFormatDefault() { | ||
Object result = run("DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzzz')"); | ||
assertTrue(result.toString().endsWith(TimeZone.getDefault().getDisplayName(true, 1))); | ||
} | ||
|
||
@Test | ||
public void testDateFormatNow() { | ||
Object result = run("DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzz', 'GMT')"); | ||
assertTrue(result.toString().endsWith("GMT")); | ||
} | ||
|
||
@Test | ||
public void testDateFormatDefaultTimezone() { | ||
Object result = run("DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzzz', epoch)"); | ||
assertTrue(result.toString().endsWith(TimeZone.getDefault().getDisplayName(true, 1))); | ||
} | ||
|
||
/** | ||
* If refer to variable that does not exist, expect ParseException. | ||
*/ | ||
@Test(expected = ParseException.class) | ||
public void testDateFormatNull() { | ||
Object result = run("DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzz', nada, 'EST')"); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we have a test for an invalid format There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any errors we need to wrap here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no exceptions thrown by any calls in this method. What are you thinking we should do?