Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-2140: [UI] Implement logic behind show/hide RESOLVE and DISMISS items in Alerts UI #1459

Closed
wants to merge 15 commits into from

Conversation

tiborm
Copy link
Contributor

@tiborm tiborm commented Jul 9, 2019

Contributor Comments

As part of this PR I'm implementing show/hide functionality for alert items based on their alert_status value. (Please note that however, the two show/hide toggle was part of the Alerts UI before, there was no actual working code behind them.)
The PR also contains a small cleanup of the surrounding code base. To implement this functionality QueryBuilder had to be made injectable. Most of the cleanup belongs to this change.

Expected behavior

If User turn on 'Hide Dismissed Alerts' or 'Hide Resolved Alerts' in the 'Hide Alerts Entries' section of the row configuration pupup the posted query should be extended with a new hidden filter.
State of the toggles should be saved to the local storage. After a page refresh, the same set of show/hide filters should apply to the requests.

show-hide-feature

Test coverage of the new code is 100% in all metrics.

Screen Shot 2019-07-09 at 3 25 35 PM

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    
  • Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@sardell
Copy link
Contributor

sardell commented Jul 12, 2019

+1. Tested with Full Dev. I'm glad to see these switches functioning as they should, and I really like that the settings are saved for the user so they do not have to set settings on every page refresh. Good stuff, @tiborm!

@mmiklavc
Copy link
Contributor

@tiborm - can you resolve the conflicts?

@tiborm
Copy link
Contributor Author

tiborm commented Jul 23, 2019

@mmiklavc Thanks for your patient! I fixed the conflicts.

@asfgit asfgit closed this in 5e1e3bd Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants