METRON-2322 Add Ambari connection check to upgrade_helper script #1566
Conversation
Test PlanI verified this in full dev and also ran shellcheck.
|
| done | ||
| echo Done backing up Ambari config... | ||
| echo Checking connection... | ||
| ret_status=$(curl -i -u "$username":"$password" -H "X-Requested-By: ambari" -X GET http://$ambari_address/api/v1/clusters/$cluster_name | head -n 1) |
There was a problem hiding this comment.
@mmiklavc I get curl: (23) Failed writing body (3631 != 15905) error constantly. Looks like the piped program head is closing the read pipe before the curl completely writes .
[root@xxx-2 bin]# ./upgrade_helper.sh backup ctr-e141-1563959304486-90868-01-000002.hwx.site:8080 admin admin hcp201-solr4-build6 Backing up Ambari config... Checking connection... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 32297 0 32297 0 0 131k 0 --:--:-- --:--:-- --:--:-- 131k curl: (23) Failed writing body (3631 != 15905) Unable to get cluster detail from Ambari. Check your username, password, and cluster name. Skipping. Skipping Metron config backup - Metron not found on this host
I ran the curl command with -s, --silent Silent mode. Don't output anything it works fine
[root@xxx-2 bin]# curl -s -i -u "admin":"admin" -H "X-Requested-By: ambari" -X GET http://ctr-e141-1563959304486-90868-01-000002.hwx.site:8080/api/v1/clusters/hcp201-solr4-build6 | head -n 1 HTTP/1.1 200 OK
There was a problem hiding this comment.
Hm, good find. When I ran this locally I did not run into this problem. I will add that change.
| echo Done backing up Ambari config... | ||
| echo Checking connection... | ||
| ret_status=$(curl -i -u "$username":"$password" -H "X-Requested-By: ambari" -X GET http://$ambari_address/api/v1/clusters/$cluster_name | head -n 1) | ||
| if [ "HTTP/1.1 200 OK" == "$ret_status" ]; then |
There was a problem hiding this comment.
This check fails for me as the ret_status has trailing white space, an extra line of code before this worked for me
ret_status ="$(echo -e "${ret_status}" | sed -e 's/[[:space:]]*$//')"
There was a problem hiding this comment.
Again, did not hit this locally. I will add the trim logic.
|
Ok @MohanDV give that a shot. I tweaked it a bit, but should still accomplish the same goal. Are you running that command on Centos 7? For Centos 6 I was not able to reproduce the issue, incidentally. |
|
+1 by verification. @mmiklavc works perfectly !! Thank you |
|
Had to resolve a conflict with master in the upgrading.md doc. Letting Travis re-run before I merge. |
Contributor Comments
https://issues.apache.org/jira/browse/METRON-2322
Note: I also added a note about this script and the original Jira to the Upgrading.md file.
Pull Request Checklist
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
n/a Have you written or updated unit tests and or integration tests to verify your changes?
n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:n/a Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.