This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-503: Metron REST API #316
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Licensed to the Apache Software | ||
| Foundation (ASF) under one or more contributor license agreements. See the | ||
| NOTICE file distributed with this work for additional information regarding | ||
| copyright ownership. The ASF licenses this file to You under the Apache License, | ||
| Version 2.0 (the "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software distributed | ||
| under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES | ||
| OR CONDITIONS OF ANY KIND, either express or implied. See the License for | ||
| the specific language governing permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.apache.metron</groupId> | ||
| <artifactId>metron-interface</artifactId> | ||
| <version>0.3.0</version> | ||
|
There was a problem hiding this comment. I believe we need to update this to 0.3.1. |
||
| </parent> | ||
| <artifactId>metron-rest-client</artifactId> | ||
| <properties> | ||
| </properties> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.apache.metron</groupId> | ||
| <artifactId>metron-common</artifactId> | ||
| <version>${project.parent.version}</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| </project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /** | ||
|
There was a problem hiding this comment. I realized after I opened the PR that there were files that had different spacing. I was planning on waiting until we finished the review process to do this because it will make it easier for you to review the incremental changes. Is that ok? There was a problem hiding this comment. @merrimanr i think that's a really good idea. You're right, changing the spaces would add a lot of distractions. |
||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.metron.rest.model; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class GrokValidation { | ||
|
|
||
| private String statement; | ||
| private String sampleData; | ||
| private Map<String, Object> results; | ||
|
|
||
| public String getStatement() { | ||
| return statement; | ||
| } | ||
|
|
||
| public void setStatement(String statement) { | ||
| this.statement = statement; | ||
| } | ||
|
|
||
| public String getSampleData() { | ||
| return sampleData; | ||
| } | ||
|
|
||
| public void setSampleData(String sampleData) { | ||
| this.sampleData = sampleData; | ||
| } | ||
|
|
||
| public Map<String, Object> getResults() { | ||
| if (results == null) { | ||
| return new HashMap<>(); | ||
| } | ||
| return results; | ||
|
There was a problem hiding this comment. This could possible result in a NPE. Does it make sense to check for this and return an empty map if that is the case? |
||
| } | ||
|
|
||
| public void setResults(Map<String, Object> results) { | ||
| this.results = results; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
|
|
||
| GrokValidation that = (GrokValidation) o; | ||
|
|
||
| if (statement != null ? !statement.equals(that.statement) : that.statement != null) return false; | ||
| if (sampleData != null ? !sampleData.equals(that.sampleData) : that.sampleData != null) return false; | ||
| return results != null ? results.equals(that.results) : that.results == null; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int result = statement != null ? statement.hashCode() : 0; | ||
| result = 31 * result + (sampleData != null ? sampleData.hashCode() : 0); | ||
| result = 31 * result + (results != null ? results.hashCode() : 0); | ||
| return result; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is very minor, but are we doing the 2 space indent rule? If so this looks to be 4.