Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-668: Remove the "tickUpdate" profile config and make the "init" phase not reset variables #420

Closed
wants to merge 10 commits into from

Conversation

cestella
Copy link
Member

Please see description at METRON-668 for a full description.

@mmiklavc
Copy link
Contributor

Excellent. And I need these fixes for some outlier analysis with HLLP and MAD. +1 by inspection.

@nickwallen
Copy link
Contributor

I like this as it simplifies the Profile configuration.

How did you test this? Did you run any profiles on "Quick Dev"?

@cestella
Copy link
Member Author

@nickwallen running as we speak. The test plan will be to generate some data like we do for the MAD outliers and construct a couple simple profiles. I'll make it a bit more explicit after I do it. :)

@cestella
Copy link
Member Author

Ok, test is complete, I made sure the profiler worked. I also adjusted the timeout on the indexing integration tests so that travis doesn't barf.

@cestella
Copy link
Member Author

The explicit test that was done on quickdev was following the Median Absolute Deviation scenario in metron-statistics

@cestella
Copy link
Member Author

By the way, please don't merge this. I'm using this branch to figure out what's going on with the build failures.

@cestella cestella closed this Jan 24, 2017
@cestella cestella reopened this Jan 24, 2017
@cestella cestella closed this Jan 25, 2017
@cestella cestella reopened this Jan 25, 2017
@asfgit asfgit closed this in c74c7de Jan 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants