-
Notifications
You must be signed in to change notification settings - Fork 512
METRON-609 Enhance Mpack to handle single-node and small-cluster installs of Elasticsearch #425
Conversation
…alls of Elasticsearch. Work in Progress, at request of David Lyle.
…e install). Partial: all improvements from METRON-634 already proved out in METRON-608.
Hi @mattf-horton - thanks for putting this up! It's got my "have to haves" plus a bunch more good stuff. I'll get working with it today. If I discover any small changes, I'll put a PR on your branch. Thanks again, this is great stuff. |
Thanks, @dlyle65535 . Couple more comments:
|
I think I can collapse both templates into 1, at least that's what I was thinking. Just so you're aware @mattf-horton (and other interested parties). I've got a METRON-671 PR coming out in the few days. It addresses a small subset of this changeset (METRON-641) and a few templating issues that will allow us to run on 1 node or 3+ nodes. It turns out, those were the only working configurations under Ansible automation. Immediately after that, I want to get this change incorporated, so I'll be testing it on the branch that deploys with Ansible using the MPack. I'm using that order so that we can accelerate the path to using the MPack in Ansible. Otherwise, we'll keep having changes in the Ansible aren't reflected in the MPack. Please let me know if that approach makes sense or if there are any concerns. Thanks! |
@dlyle65535 , makes sense to me. METRON-671 is very important for rationalizing our install scenarios, and clearly these fixes can be pipelined as you describe. I'm super glad you're picking these up. FYI, the METRON-634 fixes included here have all been proven out in my single-node installer, which I've used quite a bit over the past month. Also, all but the last 2 of the 12 items "not affecting the Ambari database" are bug fixes, not enhancements, without which some piece or other of the ES installation doesn't work correctly in today's Mpack, at least with Centos7. |
@dlyle65535 , I see that changes necessary to single-node, in slave.py and elastic_slave.py, were in my METRON-634 commit rather than the METRON-609 commit. Sorry for the oversight. |
What is the status of this? How is it related to METRON-608? |
Withdrawn. Much of this has been incorporated in other PRs already accepted. The remaining part is in METRON-865, formerly a sub-task of METRON-609, but now raised to a regular Bug jira ticket. |
This PR is not ready for prime time, but is provided for ease of access to work-in-progress for:
These are presented as two separate commits, so you can look at them separately if you wish.
These are the included enhancements from METRON-609:
These are the included enhancements and bug fixes from METRON-634:
NOT AFFECTING THE AMBARI DATABASE:
CHANGES THAT DO AFFECT THE AMBARI DATABASE:
NOTE that these changes, because they affect the database, should properly be accompanied by a database update script and a version increment in the Mpack version number. This is not currently implemented.