This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 512
METRON-733: Remove Geo database from ParserBolt #461
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this mean you can get rid of the local geo database in the parsers resource dir? |
Updated to drop the local geo database in parsers |
The build error does not seem related to your PR. I saw the same failure on #450. The resource
|
@nickwallen it is a separate issue. https://issues.apache.org/jira/browse/METRON-734 exists to track and fix it |
I am seeing this on my local branch, not the PR
On February 22, 2017 at 09:13:12, Nick Allen (notifications@github.com) wrote:
The build error does not seem related to your PR. I saw the same failure on
#450 <#450>.
The resource com.fasterxml:oss-parent:pom:28 really does not exist in Maven
Central, AFAIK. Hmm.
[ERROR] Failed to execute goal on project metron-enrichment: Could not
resolve dependencies
for project org.apache.metron:metron-enrichment:jar:0.3.1:
Failed to collect dependencies at com.maxmind.geoip2:geoip2:jar:2.8.0 ->
com.maxmind.db:maxmind-db:jar:1.2.1 ->
com.fasterxml.jackson.core:jackson-databind:jar:2.9.0-SNAPSHOT:
Failed to read artifact descriptor for
com.fasterxml.jackson.core:jackson-databind:jar:2.9.0-SNAPSHOT:
Could not find artifact com.fasterxml:oss-parent:pom:28 in central
(http://repo.maven.apache.org/maven2) -> [Help 1]
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#461 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABD1_98dtsK9jFWAsUhiM3fkRJZzHr_Kks5rfEJ3gaJpZM4MIH4d>
.
|
justinleet
force-pushed
the
geo_profiler_fix
branch
from
February 23, 2017 16:53
7ebdaff
to
519c661
Compare
+1 by inspection, looks good! Thanks @justinleet |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To create the original problem, just run up a parser and make sure there's no geo data on hdfs (by default in /apps/metron/geo).
This PR removes geo from metron-parsers entirely (since it shouldn't be necessary at all, only pulled in when Stellar cares about it).
Testing
To validate this, I basically ran through the squid demo with the geo file missing, which works as expected (no exception thrown). In addition, the ParserBoltTest is updated to not have a reference to the test Geo DB data (and runs fine without it).
To ensure that Stellar GEO_GET works as expected in a parser, quick-dev was spun up. The steps for squid were followed, but with a custom parser config
Either update global.json with a valid geo.hdfs.file or run
/usr/metron/0.3.1/bin/geo_enrichment_load.sh -z node1:2181 -r /apps/metron/geo/default/
to place the file in the default spot (instead of a timestamped stop). This is necessary to ensure that the push doesn't clobber geo configs.The resulting data in the index includes