This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-891: Changed Kafka API to Create a KafkaConsumer Per Request #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this with full dev and worked great. I noticed some tags snuck into a couple of the license headers. I think Intellij does this when you reformat. Not sure if people would have a problem with that or not. Nice work +1 |
jjmeyer0
force-pushed
the
METRON-891
branch
2 times, most recently
from
d24185a
to
0324c0b
Compare
|
@merrimanr I reverted the license headers back just in case. |
|
They sneak in because most of our license headers are Javadoc ( |
|
@merrimanr @justinleet Accidentally clicked close/comment. Sorry about that. Anyway, does this look good to you all now that the licenses are fixed? |
|
Looks good to me. Thanks @jjmeyer0. |
|
I'm set, +1 |
jjmeyer0
force-pushed
the
METRON-891
branch
2 times, most recently
from
00bbc04
to
ef6ad3e
Compare
…ead to prevent possible concurrency issues. METRON-891: Updated kafka to use spring's ConsumerFactory functionality for Kafka. This will help with potential multi-threading issues. METRON-891: Fixed unit test issues and checkstyle issues. METRON-891: Really updating dependencies... METRON-891: Fixing license after autoformat add p tags around link. METRON-891: fixed license after autoformat.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
[Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]
I stood up full-dev and made sure all kafka endpoints continue to work. I also created a postman script that uses this to execute the postman scripts in parallel. I executed a few thousand requests against the API with no issue.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.