METRON-1102: Add support for ingesting cybox URI observables from taxii feeds #689
Conversation
Testing plan should be the same as here |
@@ -38,6 +39,7 @@ | |||
import java.util.Map; | |||
|
|||
public class StixExtractor implements Extractor { | |||
private static final Logger LOG = Logger.getLogger(StixExtractor.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this ended up starting live as a patch against an older branch that I just made current. I changed the logging to use slf4j now. Good eye, @simonellistonball
So, I think this is a great addition, but I have some comments.
|
Ok, so good questions @ottobackwards . I'll do my best to answer them, but the answer to some of these expands past this PR and to the history of Taxii support for Metron (which was one of the first things we added and thus at a period of time where documentation was scarcer than it is even now ;) )
Ok, so it's apparent that some of the design decisions around taxii never made it into documentation. A couple of questions for you:
Just a note on the second, we chose that because it was the only game in town other than parsing the XML ourselves and it was the officially supported library. I even looked into that and decided against it as the XML format is extremely complex with lots of referential links that need to get coalesced to handle the blocks of stix that come across. |
What I mean is, can we import a file that is ONLY cybox observables, without Stix. Stix supports cybox. But they are separate things. |
As for where... over in METRON-777 @mmiklavc is talking about a better documentation area... this may fall into that |
Ah, for the moment we only have the StixExtractor. We could MAKE a cybox extractor and it could reuse the handler logic, but we haven't done that. Have you seen people ingesting cybox (or stix for that matter) outside of taxii? |
Yeah, it seems to me that we might need something like a location for discussion and description of architectural decisions made. |
I would like to see at least the version of Stix and Cybox that is supported documented. |
Sure, not a problem. I noted the versions supported in the documentation and linked to the actual schemata for cybox and stix. |
+1 by inspection. |
Contributor Comments
There is value in ingesting URIs from taxii feeds and we should provide support to do so.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html
:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.