METRON-1131: The Stellar REPL rejects valid hostnames for zookeeper in its CLI options

[cestella]

Contributor Comments

Currently, the REPL defines a valid zookeeper hostname is one which matches a regex rather than defining it as a hostname which is reachable by the machine. Combining this with the fact that the regex to validate the hostname is denying valid hostnames:

 @Test
  public void testBadPattern() throws Exception
  {
    Pattern validHostNamePattern = Pattern.compile(
            "^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\\\\-]*[a-zA-Z0-9])\\\\.)"
                    + "*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\\\\-]*[A-Za-z0-9])$");
    Assert.assertFalse(validHostNamePattern.matcher("gzcf0.fold.blarg.com").matches());
    Assert.assertTrue(validHostNamePattern.matcher("host1").matches());
  }

I reimplemented the hostname validator using InetAddress, which will try to resolve the hostname rather than just use a regex.

Testing this on fulldev:

• Run $METRON_HOME/bin/stellar -z node1:2181 and ensure REPL starts
• Run $METRON_HOME/bin/stellar -z blarginghammetronzoinkburger:2181 and ensure REPL does not start with Zookeeper Option blarginghammetronzoinkburger is not a valid host name or ip address blarginghammetronzoinkburger:2181

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[nickwallen]

+1 Solid!

[mmiklavc]

+1 by inspection. Thanks for fixing this.

[ottobackwards]

+1 on inspections, and +1 apology :(

[mmiklavc]

I give it a ++1 now that I've validated in full dev. Succeeds and fails as expected.

[cestella]

@ottobackwards no apology necessary, man :)