Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1145: Profiler mpack does not create kafka acl and hbase acls correctly in kerberized cluster #726

Closed
wants to merge 2 commits into from

Conversation

cestella
Copy link
Member

Contributor Comments

Title says it all. The management pack will not start the profiler in a kerberized cluster due to us not setting the acls correctly for the hbase tables and kafka group acls.

To test this, spin up full-dev, kerberize it and ensure the profiler topology starts without error.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@ottobackwards
Copy link
Contributor

You should add something to the PR Template
[ ] Does this require ACL's

or something

@cestella
Copy link
Member Author

haha actually, it's more like, "if a mpack, have you tested on kerberized full-dev"

@merrimanr
Copy link
Contributor

Tested this in full dev with Kerberos enabled. The profiler topology starts up without issue and data appears in HBase after creating a profile. +1

@asfgit asfgit closed this in 31d99f1 Aug 31, 2017
@@ -59,6 +60,9 @@ def configure(self, env, upgrade_type=None, config_dir=None):
commands.create_hbase_tables()
if params.security_enabled and not commands.is_hbase_acl_configured():
commands.set_hbase_acls()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that we do not call commands.set_hbase_acl_configured() here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to bring this up on an old, closed PR, but I am currently trying to track a bug that is giving me an uber headache. :) Thought this was the easiest way to reach out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickwallen It happens at the end of set_hbase_acls()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, daft, you're right. It works different than the Kafka ACL functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants