Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1215: Fix link to RPMs chapter #776

Closed
wants to merge 1 commit into from

Conversation

DimDroll
Copy link
Contributor

Contributor Comments

[Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@justinleet
Copy link
Contributor

+1, was able to see it work in Github's view. Thanks a lot for the fix.

@justinleet
Copy link
Contributor

@DimDroll Can you put the jira number at the front of the PR name like the other PRs have please?

@DimDroll DimDroll changed the title Fix link to RPMs chapter METRON-1215 Fix link to RPMs chapter Sep 28, 2017
@DimDroll DimDroll changed the title METRON-1215 Fix link to RPMs chapter METRON-1215: Fix link to RPMs chapter Sep 28, 2017
@DimDroll
Copy link
Contributor Author

@justinleet, sure, done:
https://issues.apache.org/jira/browse/METRON-1215
I thought for such minor change jira case would be overkill :)

@simonellistonball
Copy link
Contributor

Do we need to ensure we're picking this from the right repos? We should probably use the nodesource rpm repo rather than relying on the centos build, which is a very very old version, and could cause issues. Adding a the repo file in might be a good call.

@justinleet
Copy link
Contributor

@simonellistonball Is that comment meant for #775? I think you're on the wrong PR

@simonellistonball
Copy link
Contributor

Yes, it is, not sure how that happened. Probably too many tabs.

@justinleet
Copy link
Contributor

@DimDroll Thanks for creating the Jira. It's a pretty small thing, but it helps keep everything consistent and makes it easy to compile and search on during releases, etc.

@asfgit asfgit closed this in a46be91 Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants