Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1366: Add an entropy stellar function #872

Closed
wants to merge 2 commits into from

Conversation

cestella
Copy link
Member

@cestella cestella commented Dec 15, 2017

Contributor Comments

Trending entropy for various volumetric statistics (e.g. netflow data) has been a useful metric for intrusion detection (see http://www.cs.bu.edu/techreports/pdf/2005-002-anomaly-mining.pdf). To wit, it makes some sense to add an entropy calculation for Stellar. Used in conjunction with the profiler and an outlier detector, we can recreate the work of Lakhina referenced above.

You can validate this from the REPL:

  • IT_ENTROPY({ 'a' : 10, 'b' : 5, 'c' : 5} ) should yield 1.5
    • By the definition of Entropy: H(X) = -p(a)*log_2(p(a)) - p(b)*log_2(p(b)) - p(c)*log_2(p(c)) = -0.5*-1 - 0.25*-2 - 0.25*-2 = 1.5
  • IT_ENTROPY({}) should yield 0.0

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

}
return ret;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for giggles

 public double stream_entropy(Map<?, Integer> counts, double logOfBase) {
    double ret = 0.0;
    if (counts == null || counts.isEmpty()) {
      return ret;
    }
    final int n = counts.values().stream().mapToInt((d) -> d).sum();
    return counts.values().stream().collect(reducing(0.0, (f) -> f.doubleValue(), (a, b) -> {
      double p = b.doubleValue() / n;
      a -= p * Math.log(p) / logOfBase;
      return a;
    }));
  }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, I actually looked at how this might impact performance as a PR against your repo here

@justinleet
Copy link
Contributor

@cestella Any response to the comment by @ottobackwards ? I glanced over it, and I like it and think it's valuable, but he's hitting at the core impl, so I don't want to +1 anything.

@cestella
Copy link
Member Author

cestella commented Jan 9, 2018

@justinleet I think that was just an alternative implementation with streams rather than explicit loops. I interpreted it as not a suggested change, but a cool new way to compute entropy.

@justinleet
Copy link
Contributor

+1. Thanks for the contribution, this is valuable to have.

@mmiklavc
Copy link
Contributor

Nice addition! +1 from me as well, via inspection.

@asfgit asfgit closed this in e127797 Jan 11, 2018
iraghumitra pushed a commit to iraghumitra/incubator-metron that referenced this pull request Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants