Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1428: Travis build failing from metron-config #908

Closed
wants to merge 1 commit into from

Conversation

mmiklavc
Copy link
Contributor

@mmiklavc mmiklavc commented Jan 24, 2018

Contributor Comments

https://issues.apache.org/jira/browse/METRON-1428

Travis is failing because of npm downstream package problems. The chain of dependencies went like this: karma-remap-istanbul ^0.2.1 -> remap-istanbul some version or another -> source-map ver 7.0.0. The problem came with an api change of sorts to source-map. remap-istanbul has made a patch version in 0.9.6 to fix the dependency, and in order to get the proper remap-istanbul version that limits the pool of source-map versions, I had to upgrade karma-remap-istanbul to 0.6.0. This fixed the chain of dependencies without seemingly breaking anything else along the way, thankfully.

I have to look at what we do with the UI libraries for licensing reporting, as I currently have no idea yet what that looks like, so I'll update that shortly. For now, I wanted to see if this gets the build working, at the very least.

Pull Request Checklist

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

@mmiklavc mmiklavc changed the title 1428: Travis build failing from metron-config METRON-1428: Travis build failing from metron-config Jan 24, 2018
@cestella
Copy link
Member

+1 lgtm

@mmiklavc
Copy link
Contributor Author

Realized the change I made is specifically for a test dependency and does not appear to affect final package dependencies from what I can see in the tgz - tar tvf metron-config-0.4.3-archive.tar.gz. We are good to go as soon as Travis finishes.

@asfgit asfgit closed this in 173ce50 Jan 24, 2018
iraghumitra pushed a commit to iraghumitra/incubator-metron that referenced this pull request Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants