This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1428: Travis build failing from metron-config #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
https://issues.apache.org/jira/browse/METRON-1428
Travis is failing because of npm downstream package problems. The chain of dependencies went like this: karma-remap-istanbul ^0.2.1 -> remap-istanbul some version or another -> source-map ver 7.0.0. The problem came with an api change of sorts to source-map. remap-istanbul has made a patch version in 0.9.6 to fix the dependency, and in order to get the proper remap-istanbul version that limits the pool of source-map versions, I had to upgrade karma-remap-istanbul to 0.6.0. This fixed the chain of dependencies without seemingly breaking anything else along the way, thankfully.
I have to look at what we do with the UI libraries for licensing reporting, as I currently have no idea yet what that looks like, so I'll update that shortly. For now, I wanted to see if this gets the build working, at the very least.
Pull Request Checklist
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?