Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-1439: Turn off git pager in platform-info script #919

Closed
wants to merge 1 commit into from

Conversation

justinleet
Copy link
Contributor

Contributor Comments

Just added a couple --no-pager args. Before you'd have to progress past the couple git pages, now they should just be part of the output.

Output should look something like this when run:

{10:08}~/Documents/workspace/metron:METRON-1439 ✗ ➭  metron-deployment/scripts/platform-info.sh
Metron 0.4.3
--
* METRON-1439
--
commit a285b83ee0153cecf24132b4aed70250040a83b0 (HEAD -> METRON-1439, upstream/master, origin/master, origin/HEAD, apache/feature/METRON-1416-upgrade-solr, master, feature/METRON-1416-upgrade-solr)
Author: nickwallen <nick@nickallen.org>
Date:   Tue Jan 30 09:31:53 2018 -0500

    METRON-1432 JDK Install Fails on Ubuntu Development Environment  (nickwallen) closes apache/metron#913
--
 metron-deployment/scripts/platform-info.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--
ansible 2.2.2.0
  config file =
  configured module search path = Default w/o overrides
--
Vagrant 1.8.1
--
Python 2.7.10
--

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Have you included steps or a guide to how the change may be verified and tested manually?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@justinleet
Copy link
Contributor Author

Sidenote, do we want to move this script to the dev-utilities dir?

@nickwallen
Copy link
Contributor

+1 works great for me. Thanks

@nickwallen
Copy link
Contributor

Sidenote, do we want to move this script to the dev-utilities dir?

I do think it would be good to move that script. Not sure where under dev-utilities though. And we can tackle as separate PR, if you like.

@ottobackwards
Copy link
Contributor

this is a user utility though, not a dev one. I would create a new support-scripts folder

@cestella
Copy link
Member

cestella commented Feb 1, 2018

so, I'm +1 on this and we probably want a discussion outside of this about where to move platform-info.sh

@justinleet
Copy link
Contributor Author

@ottobackwards Any objections to having the discussion outside of this and merging this in as-is?

@ottobackwards
Copy link
Contributor

No, I am sorry, I thought that was understood. I have not reviewed, but I would go ahead based on @cestella

@asfgit asfgit closed this in 567d106 Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants