SSHD-930 Send the client version string after receiving the version string of the server #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoldstein
force-pushed
the
SSHD-930
branch
2 times, most recently
from
882fb89
to
947442d
Compare
tomaswolf
reviewed
Jul 10, 2019
sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java
Show resolved
Hide resolved
lgoldstein
force-pushed
the
SSHD-930
branch
2 times, most recently
from
1142ce5
to
f7bde2c
Compare
tomaswolf
approved these changes
Jul 15, 2019
sshd-core/src/main/java/org/apache/sshd/client/session/ClientProxyConnector.java
Outdated
Show resolved
Hide resolved
sshd-core/src/main/java/org/apache/sshd/client/session/AbstractClientSession.java
Outdated
Show resolved
Hide resolved
sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java
Show resolved
Hide resolved
sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java
Show resolved
Hide resolved
lgoldstein
force-pushed
the
SSHD-930
branch
2 times, most recently
from
2860d94
to
5af7bba
Compare
|
Looks OK to me. Detailed review of diff between this force-push and f7bde2c not possible for me on Github; I hadn't fetched the previous state. |
added 5 commits
July 18, 2019 14:19
…identification until after the server's was received
…eceived while KEX not yet completed
… a peer proposal is not yet set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave default to be same as current - i.e., immediate