Fix hang in PortForwardingTest #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaswolf
force-pushed
the
debug-port-forwarding
branch
from
f9d8bf4
to
c92c6d5
Compare
PortForwardingTest did hang sometimes in GitHub CI (Windows/Java 1.8). Also: don't redirect test output to a file; these files are not accessible once a GitHUb CI pod has terminated. By not redirecting, the GitHUb CI build log has much more information useful to analyze potential problems.
tomaswolf
force-pushed
the
debug-port-forwarding
branch
from
c92c6d5
to
3c2e8b6
Compare
tomaswolf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP/IP forwarding: always resume reading, even in error cases
PortForwardingTest did hang sometimes in GitHub CI (Windows/Java 1.8).
Also: don't redirect test output to a file; these files are not
accessible once a GitHUb CI pod has terminated. By not redirecting,
the GitHUb CI build log has much more information useful to analyze
potential problems.