[SSHD-1303] AbstractClientChannel: use null stream for redirected stderr #255
Conversation
If a channel's error stream has been redirected to the output stream, return null streams from getAsyncErr() and getInvertedErr(). Since they are redirected, application code should never see any data on them. Also document the IoReadFuture better, and change the single implementation of that interface to match. While the future is not done, operations return null or zero. EOF is signaled by getRead() == -1, or getException() returning an EOFException.
| @@ -474,4 +494,48 @@ public Integer getExitStatus() { | |||
| public String getExitSignal() { | |||
| return exitSignalHolder.get(); | |||
| } | |||
|
|
|||
| private enum NullIoInputStream implements IoInputStream { | |||
There was a problem hiding this comment.
Recommend making this a public class in same package as IoInputStream or a member of it. Might come useful in the future.
There was a problem hiding this comment.
Then let's delay doing so to that future until a second concrete use case for this comes up. YAGNI. Which basically means "implement features when they're actually needed, not when you think they might be needed."
My personal philosophy is that if something is relatively simple, generic enough to be useful then why not make it public.
I agree in principle, though it has been my experience that usually you are going to need it. That being said, I have no issue with leaving this code as-is - like I said, I recommend it, but do not insist on it... |
If a channel's error stream has been redirected to the output stream, return null streams from getAsyncErr() and getInvertedErr(). Since they are redirected, application code should never see any data on them.
Also document the IoReadFuture better, and change the single implementation of that interface to match. While the future is not done, operations return null or zero. EOF is signaled by getRead() == -1, or getException() returning an EOFException.