GH-407: Override FilterOutputStream.write(byte[], int, int) #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation calls write(int) for every byte, which may be very inefficient. Override it in the few cases where we use a FilterOutputStream to pass through the operation to the underlying OutputStream, which is also responsible for any index and length validations. Bug: apache#407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation calls write(int) for every byte, which may be very inefficient. Override it in the few cases where we use a FilterOutputStream to pass through the operation to the underlying OutputStream, which is also responsible for any index and length validations.
Fixes #407.