Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSHD-1330] Using common keep-alive global request handler in client as well as server #416

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

lgoldstein
Copy link
Contributor

No description provided.

@lgoldstein
Copy link
Contributor Author

@tomaswolf Please review and merge if you are satisfied - thx.

@tomaswolf
Copy link
Member

Moving the KeepAliveHandler to a different package will break any code that currently references it using the old package. Not sure how to deal with this.

@lgoldstein
Copy link
Contributor Author

Valid point, but IMO

  • The change is minor - package shift - so easily fixed whenever the referencing code is re-compiled with the new version
  • I doubt there is much existing code referencing it directly
  • Not the first time we shifted some classes + not something we are doing often

In view of this I think we can safely merge this piece of code.

@tomaswolf tomaswolf merged commit 1283515 into apache:master Sep 25, 2023
8 checks passed
@lgoldstein lgoldstein deleted the SSHD-1330 branch September 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants