Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix bug for Dropout with axes, also adding unit test #10030

Merged
merged 2 commits into from Mar 8, 2018

Conversation

zhanghang1989
Copy link
Contributor

@zhanghang1989 zhanghang1989 commented Mar 8, 2018

Description

  1. Fix bug/typo in previous PR Add axes support to Dropout for variational dropout in NLP #9931
  2. Add unit test for new feature Dropout with axes (variational dropout)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Dropout operator with axes, unit tests

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@szha szha merged commit 117c509 into apache:master Mar 8, 2018
@szha
Copy link
Member

szha commented Mar 8, 2018

Thanks. Let's add a jira retroactively when you figure out how.

@zhanghang1989 zhanghang1989 deleted the drop1 branch March 8, 2018 01:45
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants