This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Static memory allocation for cached_op (#10817)" #11311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#10817)" This reverts commit 2dbd143.
|
can we move forward instead of backward? |
|
close due to bugfix introduced in #11310 |
|
CI has not yet passed, and this is a self-merging... |
piiswrong
added a commit
to piiswrong/mxnet
that referenced
this pull request
Jun 15, 2018
…ed_op (apache#10817)" (apache#11311)" This reverts commit e48a8fd.
|
I'd like to introduce you to the Apache guidelines: https://www.apache.org/foundation/voting.html "2. Code modifications" |
|
with great power comes great responsibility. I would never abused that power to any changes just to make a point and bring things backward. |
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…pache#10817)" (apache#11311) This reverts commit 2dbd143.
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…pache#10817)" (apache#11311) This reverts commit 2dbd143.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2dbd143.
See #11171 for reference. #10817 has not been approved and is causing regressions.