Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Test for new int64 type in CSVIter #11499

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Jun 29, 2018

Description

Previous int64 data type for CSVIter PR was merged but forgot a special test for it.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Unit test for int64 data type support for CSVIter

Comments

@haojin2
Copy link
Contributor Author

haojin2 commented Jun 29, 2018

@szha

@szha
Copy link
Member

szha commented Jun 29, 2018

@haojin2 thanks for adding the test for #11446

@szha szha merged commit ebfc16e into apache:master Jun 29, 2018
@haojin2 haojin2 deleted the CSVIter_int64_test branch July 19, 2018 20:11
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants