This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
ColorNormalizeAug now accepts mxnet NDArrays as well as stated (wrongly) in the documentation. #11606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the doc of mx.image.ColorNormalizeAug mean and std must be mxnet NDArrays though in reality it accepts only numpy arrays. This commit allows ColorNormalizeAug to accept both numpy and mxnet ndarrays. Extended the image unit tests to cover this functionality.
marcoabreu
reviewed
Jul 8, 2018
tests/python/unittest/test_image.py
Outdated
| @@ -155,6 +155,17 @@ def test_imageiter(self): | |||
|
|
|||
|
|
|||
| def test_augmenters(self): | |||
There was a problem hiding this comment.
Please add the with-seed annotation
There was a problem hiding this comment.
Could you please point me to an example so I can add it?
There was a problem hiding this comment.
Nevermind, found it :)
zhreshold
approved these changes
Jul 9, 2018
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…ly) in the documentation. (apache#11606) * ColorNormalizeAug now accepts mxnet NDArrays as well. According to the doc of mx.image.ColorNormalizeAug mean and std must be mxnet NDArrays though in reality it accepts only numpy arrays. This commit allows ColorNormalizeAug to accept both numpy and mxnet ndarrays. Extended the image unit tests to cover this functionality. * Fixed missing brackets * Simplified assert call according to pylint * Fixed linting issue * Fixed namespace issue * Fixed std and mean assignment * Fixed isinstance python3 mode * Added with_seed annotation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc of mx.image.ColorNormalizeAug mean and std must be mxnet NDArrays though in reality it accepts only numpy arrays. This commit allows ColorNormalizeAug to accept both numpy and mxnet ndarrays.
Extended the image unit tests to cover this functionality.