This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
MKLDNN Forward FullyConnected op cache #11611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, please add a test to ensure the caching works as expected |
|
Which version of mkldnn is suitable for this PR? |
|
The PR is based on release v0.14 version. Thanks. |
|
@azai91 could you help review |
sandeep-krishnamurthy
added
MKLDNN
Backend
azai91
reviewed
Aug 21, 2018
| ipFwd_pd.bias_primitive_desc(), bias->get_data_handle())); | ||
| else | ||
| this->bias->set_data_handle(bias->get_data_handle()); | ||
| if (this->ipFwd == nullptr) |
azai91
reviewed
Aug 21, 2018
| if (param.no_bias) { | ||
| MKLDNNStream::Get()->RegisterPrim(mkldnn::inner_product_forward( | ||
| ipFwd_pd, *data_mem, *weight_mem, *out_mem.second)); | ||
| FCFwd.ipFwd_pd.dst_primitive_desc(), req[fullc::kOut]); |
There was a problem hiding this comment.
pass in_data as last argument for CreateMKLDNNMem in case req is WriteInPlace
|
approve conditional on adding that param to CreateMKLDNNMem so we can support kWriteInPlace. |
azai91
approved these changes
Aug 21, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
* Enable primitive allocation cache for FullyConnected * Enable primitive allocation cache for FullyConnected * fix indent and pass in_data as last argument for CreateMKLDNNMem * fix indent and pass in_data as last argument for CreateMKLDNNMem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable primitive allocation cache for FullyConnected, separate from PR #11301
@zheng-da , @pengzhao-intel, @ZhennanQin
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments