Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Added the diag() operator #11643

Merged
merged 21 commits into from
Jul 19, 2018
Merged

Added the diag() operator #11643

merged 21 commits into from
Jul 19, 2018

Commits on Jul 19, 2018

  1. Added np.diag as mxnet operator, WIP 

    Done:
2d input forward pass
Missing:
1d input forward
all backward
    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    157e3fe View commit details
    Browse the repository at this point in the history

  2. Added a simple gradient transfer backwards operator for diag 

    Fixed small typos as well
    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    82ff682 View commit details
    Browse the repository at this point in the history

  3. Finished backward operation

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    182f11b View commit details
    Browse the repository at this point in the history

  4. Added full support for k

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    0581d45 View commit details
    Browse the repository at this point in the history

  5. Finished added the 1D case to the diag operator 

    Finished function documentation
Added unit tests
    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    eb5f17a View commit details
    Browse the repository at this point in the history

  6. Fixed cpplinter errors in the diag operator 

    Issues were extra white spaces and include order
    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    cb89c76 View commit details
    Browse the repository at this point in the history

  7. Fixed indentation in diag_op-inl.h

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    95b5560 View commit details
    Browse the repository at this point in the history

  8. Changed diag operator tests to use np.diag() as comparison

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    a291e81 View commit details
    Browse the repository at this point in the history

  9. Fixed kernel bug in gpu diag operator

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    bb4c8d1 View commit details
    Browse the repository at this point in the history

  10. Replaced the min operator with an inline if statement.

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    7131e72 View commit details
    Browse the repository at this point in the history

  11. Added diag to ndarray and symbol

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    ac7feba View commit details
    Browse the repository at this point in the history

  12. Replaced the type of parameter k from int32 to nnvm::dim

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    0b0fe12 View commit details
    Browse the repository at this point in the history

  13. Added default argument to k in ndarray and symbol

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    57b9345 View commit details
    Browse the repository at this point in the history

  14. Fixed ndarray and symbol diag calls

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    6b99f45 View commit details
    Browse the repository at this point in the history

  15. Fixed the optional k parameter

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    a613f49 View commit details
    Browse the repository at this point in the history

  16. Fixed cpp linting error

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    869e198 View commit details
    Browse the repository at this point in the history

  17. Changed test data datatype to float32

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    d02e221 View commit details
    Browse the repository at this point in the history

  18. K values resulting into 0-sized diagonals will now throw an exception. 

    Added matching test case
    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    17cdcf9 View commit details
    Browse the repository at this point in the history

  19. Fixed unittest

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    fc2a2ca View commit details
    Browse the repository at this point in the history

  20. Added diag to NDArray and Symbol api doc

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    702b416 View commit details
    Browse the repository at this point in the history

  21. Added missing api doc

    @ifeherva
    ifeherva committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    7fd3b8c View commit details
    Browse the repository at this point in the history