Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update mkldnn to 0.16 #12265

Closed
wants to merge 1 commit into from
Closed

Conversation

azai91
Copy link
Contributor

@azai91 azai91 commented Aug 20, 2018

Description

update mkldnn submodule to 0.16

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • update mkldnn submodule to 0.16

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv
Copy link
Member

TaoLv commented Aug 21, 2018

Hi Alex, thanks for bring this up. So far as I know, mkl-dnn introduced in padding format for better performance recently and it would require more memory for computation, compared with the logical size of tensor. In the existing integration code, we are re-using those memory from input/output NDArray for computation and they are allocated according to the logical size during memory planning phase. So I don't think we can simply update mkl-dnn to 0.16 at this time. I have talked with @zheng-da and @eric-haibin-lin about that and we are also trying to figure out a work around before we can change the behavior of memory planning for mkldnn backend. @pengzhao-intel

@eric-haibin-lin
Copy link
Member

@TaoLv thanks for the heads-up. It would be great if you can share the design/plan on how you want to change memory planning to achieve this

@kalyc
Copy link
Contributor

kalyc commented Sep 14, 2018

Thanks for your contribution @azai91
@mxnet-label-bot[pr-awaiting-response]

@marcoabreu marcoabreu added the pr-awaiting-response PR is reviewed and waiting for contributor to respond label Sep 14, 2018
@azai91 azai91 closed this Sep 24, 2018
@azai91
Copy link
Contributor Author

azai91 commented Oct 23, 2018

@TaoLv any plans to upgrade 0.16? a few people within amazon are inquiring.

@TaoLv TaoLv mentioned this pull request Oct 24, 2018
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants