This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1377] Add static-dependencies licenses #14726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
reviewed
Apr 17, 2019
szha
approved these changes
Apr 17, 2019
|
Can you also clean up the license stuff in build_lib.sh? |
lanking520
force-pushed
the
static-license
branch
from
50d8212
to
246afce
Compare
kedarbellare
pushed a commit
to kedarbellare/incubator-mxnet
that referenced
this pull request
Apr 20, 2019
* add static-dependencies licenses * add rat-exclude * kill licenses copying
perdasilva
reviewed
Apr 23, 2019
| @@ -48,12 +47,6 @@ if [[ $VARIANT == *mkl ]]; then | |||
| cp 3rdparty/mkldnn/build/install/lib/$IOMP_LIBFILE lib | |||
| cp 3rdparty/mkldnn/build/install/lib/$MKLML_LIBFILE lib | |||
| cp 3rdparty/mkldnn/build/install/lib/$MKLDNN_LIBFILE lib | |||
| cp 3rdparty/mkldnn/build/install/$MKLDNN_LICENSE lib | |||
There was a problem hiding this comment.
Do we not need to copy the mkl-dnn and cub licenses anymore?
I couldn't find them in LICENSE.binary.dependencies.
Also, these changes have broken the pip/setup.py. I will post a PR and add you as reviewer =)
There was a problem hiding this comment.
We are also including the contents of the source LICENSE (LICENSE in the main folder) as well which contains both mkldnn and cub
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add static-dependencies licenses * add rat-exclude * kill licenses copying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add licences for all static-dependencies. These licenese are not applicable to user who chose to build from source with all depdendencies dynamically-linked. But static-linking are required to place it under the generated package (e.g pip wheel, maven jars).
@zachgk @szha
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.