Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Expose get_all_registered_operators and get_operator_arguments in the… #15364

Merged
merged 3 commits into from Jul 4, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Jun 25, 2019

… Python API.

Resolves #15367

@sandeep-krishnamurthy

Checklist

I checked that opperf.py runs with the changes provided.

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy requested a review from szha as a code owner June 25, 2019 23:23
@sandeep-krishnamurthy
Copy link
Contributor

Thanks @larroy

Overall looks good to me. However, this is adding 2 new public facing APIs. I prefer you create a RFC github issue, have a discussion and get community feedback on the same.

@larroy
Copy link
Contributor Author

larroy commented Jun 26, 2019

@marcoabreu addressed your comments.

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jun 28, 2019
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM. Thank you!

@wkcn wkcn added pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-merge Review and CI is complete. Ready to Merge labels Jul 4, 2019
@wkcn
Copy link
Member

wkcn commented Jul 4, 2019

If there is not any propose in the RFC, it's good to merge.

@wkcn wkcn merged commit 0ec4886 into apache:master Jul 4, 2019
@wkcn
Copy link
Member

wkcn commented Jul 4, 2019

Merged. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Add public functions to get list of registered operators and arguments
5 participants