This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Opperf] Add optimizer update operator benchmarks to opperf #15522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiBapchya
force-pushed
the
opperf_optimizer
branch
from
28a3ce3
to
a277341
Compare
ChaiBapchya
changed the title
|
@mxnet-label-bot add [Benchmark, Operator] |
larroy
reviewed
Jul 16, 2019
|
Thanks for the contribution. I don't see params such as grad, momentum etc. in this PR, how are you creating those parameters for these optimizers benchmarks? |
larroy
approved these changes
Jul 26, 2019
|
@ChaiBapchya - Can you take a look at CI failures? |
|
@sandeep-krishnamurthy Yup, good to review. Thanks. |
sandeep-krishnamurthy
approved these changes
Jul 28, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
…5522) * optimizer for opperf benchmark * Trigger notification * missed function call * added params * minor typos * Trigger notification * resolve default params * temp remove multi op * take care of apache#15643 * numbering typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added neural network optimizer (Adam, sgd, etc) update operators to the existing set of opperf benchmarks
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
@sandeep-krishnamurthy @apeforest