Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

julia: bump Windows prebult binary version to v1.5.0 #15608

Merged
merged 1 commit into from Jul 20, 2019

Conversation

iblislin
Copy link
Member

  • remove file REQUIRE, it's stale for Pkg3.jl
  • this patch has been included in the Julia package v1.5.x branch (dmlc/MXNet.jl@73e0fba)

@marcoabreu
Copy link
Contributor

marcoabreu commented Jul 19, 2019

Sorry, but it seems like we're breaking the Apache rules regarding releases and code ownership here. (I know it's nothing new you introduced here, but it just got my attention)

Could you elaborate why you're referencing an external repository and explain how the code ownership of the Julia package is looking like exactly. I was under the impression that the Julia package is now completely part of the Apache Incubator and thus the DMLC repository is only acting as mirror for legacy reasons.

@iblislin
Copy link
Member Author

Hi @marcoabreu, the discussion is here:
http://mail-archives.apache.org/mod_mbox/mxnet-dev/201901.mbox/%3cc3eb9aa6-889a-6e32-b443-99d41dcd4b37@hs.ntnu.edu.tw%3e

I selected that old MXNet.jl repo as the release channel for Julia package.

@iblislin
Copy link
Member Author

This branch (https://github.com/dmlc/MXNet.jl/tree/v1.5.x) is created by git-subtree command mentioned in the mailing list.

@marcoabreu
Copy link
Contributor

Ah I remember, thanks. Go ahead :)

@iblislin
Copy link
Member Author

BTW, if I want to backport this patches to v1.5.x branch, what is the backport process?

@marcoabreu
Copy link
Contributor

You can choose the target branch when you edit the PR. It's at the top.

@iblislin
Copy link
Member Author

I want this PR get merged into both master and v1.5.x branch. I think it's not possible in single PR... Is there a backport process developed?

@marcoabreu
Copy link
Contributor

Correct, you have to make two separate prs.

As far as the process is define, we only prepend "[1.5.x]" to the PR title and set the target branch. Then we wait for CI to pass and one approval.

@marcoabreu
Copy link
Contributor

Ah, and we cherry pick commits from master if possible.

@iblislin
Copy link
Member Author

ah, okay!

@iblislin
Copy link
Member Author

I think the CI failures are unrelated.
Reopen PR to rerun CI.

@iblislin iblislin closed this Jul 19, 2019
@iblislin iblislin reopened this Jul 19, 2019
- remove file REQUIRE, it's stale for Pkg3.jl
@iblislin iblislin merged commit d5df247 into master Jul 20, 2019
@iblislin iblislin deleted the ib/dump-win-prebult branch July 20, 2019 14:17
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
- remove file REQUIRE, it's stale for Pkg3.jl
iblislin added a commit that referenced this pull request Sep 11, 2019
- remove file REQUIRE, it's stale for Pkg3.jl
iblislin added a commit that referenced this pull request Dec 17, 2019
* julia: bump window prebult binary version to v1.5.0 (#15608)

- remove file REQUIRE, it's stale for Pkg3.jl

* update julia install doc (#15609)

* julia: fix `mx.forward` kwargs checking (#16138)

close dmlc/MXNet.jl#431

* Julia: add API docs back (#16348)

`ndarray` and `symbolic-node` have been refactored by splitting into a
few files in commits ed83071 and 36a3cb8, but the corresponding
document setting for MXNet.jl is not updated yet.

List all split source files into the `at_autodoc` setting.

Also refer to the `at_autodoc` setting in `julia/docs/src/api/optimizer.md`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants