Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.5.x] fix fp32 flatten issue (#15351) #15802

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

juliusshufan
Copy link
Contributor

@juliusshufan juliusshufan commented Aug 8, 2019

  • Fix flatten issue before slice op

  • fix cpplint

  • address comments

  • retrigger CI

  • trigger CI

  • retrigger CI

  • use SupportMKLDNNReshape and update operator list

Description

cherry-picking PR#15351

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@juliusshufan juliusshufan requested a review from szha as a code owner August 8, 2019 09:31
@juliusshufan juliusshufan changed the title fix fp32 flatten issue (#15351) [v1.5.x] fix fp32 flatten issue (#15351) Aug 8, 2019
* Fix flatten issue before slice op

* fix cpplint

* address comments

* retrigger CI

* trigger CI

* retrigger CI

* use SupportMKLDNNReshape and update operator list
@juliusshufan
Copy link
Contributor Author

@wuxun-zhang This PR cherry-picking your commit merged on master branch for v1.5.1 release, could you please review it? Thanks.

@wuxun-zhang
Copy link
Contributor

Thanks @juliusshufan. Looks good to me.

@TaoLv TaoLv merged commit 386ad26 into apache:v1.5.x Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants