Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Numpy vstack #15850

Merged
merged 1 commit into from Sep 21, 2019
Merged

[Numpy] Numpy vstack #15850

merged 1 commit into from Sep 21, 2019

Conversation

hzfan
Copy link
Contributor

@hzfan hzfan commented Aug 11, 2019

Description

Numpy compatible vstack with existing kernel from concat
vstack

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • add stack internal interface
  • add python interface
  • add unit tests

Comments

Thank @reminisce @haojin2 for guidance and review.

@hzfan hzfan requested a review from szha as a code owner August 11, 2019 17:40
@szha
Copy link
Member

szha commented Sep 17, 2019

@hzfan could you resolve conflict?

@hzfan
Copy link
Contributor Author

hzfan commented Sep 17, 2019

@szha conflicts resolved.

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @haojin2 would you like to take another pass?

@reminisce reminisce merged commit 11f73ed into apache:master Sep 21, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants