Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Numpy compatible dstack #15871

Merged
merged 3 commits into from Oct 11, 2019

Conversation

mikemwx
Copy link
Contributor

@mikemwx mikemwx commented Aug 13, 2019

Description

Numpy compatible dstack with existing kernel from concat
Numpy dstack

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [] Changes are complete (i.e. I finished coding on this PR)
  • [] All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Shape Inference added in src/operator/numpy/np_matrix_op.cc
  • Forward and Backward compute in src/operator/nn/concat-in.h
  • CPU and GPU registration in src/operator/numpy/np_matrix_op.cc and src/operator/numpy/np_matrix_op.cu
    Pass CPU/GPU and lint tests.

Test Case Covered

  • scalar tensor
  • zero size tensor
  • tensors with number of dimensions from 1 to 4

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here
    Thank @haojin2 and @reminisce for guidance and reviewing!

Rgister dstack on GPU

Minor comment fix

Minor syntax fix

Syntax fix according to comments

header fix
@haojin2 haojin2 changed the base branch from master to numpy_pr_merge October 11, 2019 21:18
@haojin2 haojin2 merged commit c13806b into apache:numpy_pr_merge Oct 11, 2019
haojin2 pushed a commit that referenced this pull request Oct 12, 2019
* Add dstack that pass CPU test

Rgister dstack on GPU

Minor comment fix

Minor syntax fix

Syntax fix according to comments

header fix

* Fix sanity
haojin2 pushed a commit that referenced this pull request Oct 13, 2019
* Add dstack that pass CPU test

Rgister dstack on GPU

Minor comment fix

Minor syntax fix

Syntax fix according to comments

header fix

* Fix sanity
haojin2 pushed a commit that referenced this pull request Oct 14, 2019
* Add dstack that pass CPU test

Rgister dstack on GPU

Minor comment fix

Minor syntax fix

Syntax fix according to comments

header fix

* Fix sanity
reminisce pushed a commit that referenced this pull request Oct 15, 2019
* Add dstack that pass CPU test

Rgister dstack on GPU

Minor comment fix

Minor syntax fix

Syntax fix according to comments

header fix

* Fix sanity
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
* Add dstack that pass CPU test

Rgister dstack on GPU

Minor comment fix

Minor syntax fix

Syntax fix according to comments

header fix

* Fix sanity
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants