This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[numpy] operator ravel, derive from reshape #16016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [Numpy, Operator, pr-awaiting-review] |
marcoabreu
added
Numpy
Operator
pr-awaiting-review
haojin2
reviewed
Sep 2, 2019
| (1, 2, 3), | ||
| (3, 0), | ||
| (1, 0, 2) | ||
| ]: |
There was a problem hiding this comment.
Simply do
for shape in [(), (2,), (2, 2), (1, 2, 3), (3, 0), (1, 0, 2)]:
tingying2020
force-pushed
the
np_ravel
branch
from
ee11c0c
to
8ce625d
Compare
sxjscience
suggested changes
Sep 11, 2019
sxjscience
suggested changes
Sep 11, 2019
sxjscience
reviewed
Sep 11, 2019
sxjscience
reviewed
Sep 12, 2019
sxjscience
reviewed
Sep 12, 2019
tingying2020
force-pushed
the
np_ravel
branch
2 times, most recently
from
076a24e
to
3c8ffc4
Compare
sxjscience
reviewed
Sep 12, 2019
sxjscience
reviewed
Sep 12, 2019
tingying2020
force-pushed
the
np_ravel
branch
2 times, most recently
from
a2fe2ed
to
cb67e82
Compare
sxjscience
approved these changes
Sep 15, 2019
|
@tingying2020 Would you rebase the code? I will merge after that. |
* it is the same as reshape(x, -1) * register reshape with prefix _npi_ * fix format error * edit examples in doc * fix error in review * add out in wrapper * remove out * test data type and add order * change order check * remove redundant test and add docstring about order
tingying2020
force-pushed
the
np_ravel
branch
from
cb67e82
to
b8f799f
Compare
Rebased. |
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* it is the same as reshape(x, -1) * register reshape with prefix _npi_ * fix format error * edit examples in doc * fix error in review * add out in wrapper * remove out * test data type and add order * change order check * remove redundant test and add docstring about order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy operator ravel which is the same as reshape(x, -1).
@haojin2