Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fixing test for model compatibility checker #16159

Merged
merged 2 commits into from Sep 16, 2019

Conversation

Vikas-kum
Copy link
Contributor

Description

adding libtvm.so to test

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Vikas-kum Vikas-kum closed this Sep 13, 2019
@Vikas-kum Vikas-kum reopened this Sep 13, 2019
@Vikas-kum Vikas-kum closed this Sep 13, 2019
@Vikas-kum Vikas-kum reopened this Sep 13, 2019
@Vikas-kum Vikas-kum closed this Sep 16, 2019
@Vikas-kum Vikas-kum reopened this Sep 16, 2019
@Vikas-kum
Copy link
Contributor Author

@anirudh2290

@anirudh2290 anirudh2290 merged commit 2a55cd7 into apache:master Sep 16, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* fixing test for model compatibility checker

* fake change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants