Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

upgrade the pytest version #16429

Merged
merged 1 commit into from Oct 10, 2019
Merged

upgrade the pytest version #16429

merged 1 commit into from Oct 10, 2019

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Oct 10, 2019

Description

this PR is aimed to address the issue: #16394

the root cause is the pytest not up-to-date. The possible fix are either go with older version of attrs library or upgrade pytest.

@TaoLv @PatricZhao @marcoabreu

This should fix the onnx test failure.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu marcoabreu merged commit 88521ff into apache:master Oct 10, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants