Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Tests of interoperability of numpy dispatch #16493

Merged
merged 1 commit into from Oct 20, 2019

Conversation

xiezhq-hermann
Copy link
Contributor

Description

Tests of interoperability of numpy dispatch, this PR covers these OPs:

  • concatenate
  • copy
  • expand_dims
  • expm1
  • norm
  • svd
  • split
  • squeeze
  • std
  • swapaxes
  • tensorfot
  • tile
  • trace
  • transpose
  • tril

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

Known common issues:

  • data type coverage
  • some module (like masked array, np.matrix, etc) not supported
  • python native scalar and list objects are not dispatchable

@reminisce Thanks for your effort to review the test codes, please feedback me any problems.

@haojin2
Copy link
Contributor

haojin2 commented Oct 15, 2019

@xiezhq-hermann please fix the CI errors.

@haojin2 haojin2 added this to In progress in numpy via automation Oct 15, 2019
@haojin2 haojin2 added the Numpy label Oct 15, 2019
norm, svd, split, squeeze, std, swapaxes, tensorfot, tile, trace, transpose, tril

fix swapaxes, sanity check issues

current svd not compatible

inputs of indentical axes supported for swapaxes, skip int tests of linalg.norm

re-factor the code structure

delete an extra blank line
@reminisce reminisce merged commit c1d02ce into apache:master Oct 20, 2019
numpy automation moved this from In progress to Done Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants