Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MXNET-1444/MXNET-1445: replace NULL by nullptr literal #17536

Closed
wants to merge 11 commits into from
Closed

MXNET-1444/MXNET-1445: replace NULL by nullptr literal #17536

wants to merge 11 commits into from

Conversation

olk
Copy link
Contributor

@olk olk commented Feb 6, 2020

  • using nullptr is more explicit
  • macro NULL can be a integer literal with value zero (since C++11)
  • literal nullptr is of type std::nullptr_t
  • as template arg NULL and 0 evaluate to integer

- MXNET-1444
- using nullptr is more explicit
- macro NULL can be a integer literal with value zero (since C++11)
- literal nullptr is of type std::nullptr_t
- as template arg NULL and 0 evaluate to integer
- MXNET-1445
- using nullptr is more explicit
- macro NULL can be a integer literal with value zero (since C++11)
- literal nullptr is of type std::nullptr_t
- as template arg NULL and 0 evaluate to integer
@leezu
Copy link
Contributor

leezu commented Feb 6, 2020

Please see CI, lint is failing:

[2020-02-06T19:25:21.265Z] include/mxnet/lib_api.h: 1 Errors of 1 Categories map={'whitespace': 1}

@olk
Copy link
Contributor Author

olk commented Feb 6, 2020

whitespace error was introduced by another commit

ae472c2 dynamic custom operator support (#15921)

I've fixed it

@leezu
Copy link
Contributor

leezu commented Feb 6, 2020

[2020-02-06T20:48:22.104Z] include/mxnet/lib_api.h:631: Lines should be <= 100 characters long [whitespace/line_length] [2]

Sorry, I didn't paste the exact error message but only the error summary before.

D-Roberts and others added 6 commits February 7, 2020 09:11
* Add np.random.pareto and np.random.power; add one test for pareto, power, weibull

* Remove previous Weibull test
* stub for optimizing Gluon block

* Init commit for Gluon hybridblocks partition(sample test included)

* Added tests for Gluon and refactored tests

* call optimize_for in _build_cache

* Pass in 4 paras for gluon optimize_for

* Fixed auxiliary state issue, args issue and added 2 tests.

* Fixed auxiliary state issue, args issue and added 2 tests.

* changed parameter check

* refactored param init since needed for partitioning

* fixed whitespace

* fixed flattened args

* fixed sanity & updated tests

* fixed whitespace

* added context support in tests

* Fix python2 errors

* clean code remove cargs

* Add hybridblock hybridize() description

Co-authored-by: guanxinq <58794120+guanxinq@users.noreply.github.com>
* Added support for remaining random sampling ops, removed exception for sample_multinomial as it does work with random data

* Dropped unused unique_ops variable

* Added affine transform, dropped parentheses, changed 19 to 18

* Dropped unique_ops condition - no longer in use

* Fixed indentation

* Dropped unique_ops
@olk
Copy link
Contributor Author

olk commented Feb 7, 2020

There was an additional whitespace error from a previous commit - I don't know why it could pass the lint check.
I've adopted my vimrc accordingly.

Could I get a link to the coding/code formatting standards used by MXNet?

@olk
Copy link
Contributor Author

olk commented Feb 7, 2020

generating Julia docs fails with:

[2020-02-07T10:19:19.325Z] raise VersionConflict(dist, req).with_context(dependent_req)
[2020-02-07T10:19:19.325Z] pkg_resources.VersionConflict: (Markdown 3.2 (/home/jenkins_slave/.local/lib/python3.5/site-packages), Requirement.parse('markdown<3.2'))

Seams to be an problem of the build system.

@olk olk closed this Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants