-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MKLDNN] Support projection feature of LSTM #17996
Conversation
Hey @zixuanweeei , Thanks for submitting the PR
CI supported jobs: [unix-gpu, miscellaneous, centos-cpu, clang, windows-gpu, unix-cpu, edge, website, centos-gpu, windows-cpu, sanity] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I will merge this PR when CI passed.
Perhaps we need to upgrade dnnl to its v1.3 release (#17972) at first. #17872 could then be fixed, and backported to MXNet-1.7 with dnnl v1.3. This PR can be finally merged into master. @ciyongch @TaoLv @pengzhao-intel |
Got it and will wait for a while. |
@mxnet-bot run [unix-gpu] |
Undefined action detected. |
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
@zixuanweeei please help resolve the conflict :) |
* cpp unittest dependency
Please note that mkldnn submodule is pinned to its v1.4-rc version in this PR. |
Thanks for the reminder. I think it's fine with 1.4-rc and we can update to 1.4 later. |
Description
As title.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@ciyongch @TaoLv @pengzhao-intel