Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKLDNN] Support projection feature of LSTM #17996

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

zixuanweeei
Copy link
Contributor

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [x ] Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Sopport projection feature using DNNL(oneDNN).
  • Add unit test for projection feature
  • Add env MXNE_USE_WEIGHT_CACHE to control the initializition behavior

Comments

  • Please note that MKLDNN is upgraded to v1.4-rc.
  • Only support Forward pass. Backward pass has not been integrated yet.

@ciyongch @TaoLv @pengzhao-intel

@mxnet-bot
Copy link

Hey @zixuanweeei , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, centos-cpu, clang, windows-gpu, unix-cpu, edge, website, centos-gpu, windows-cpu, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Apr 8, 2020
CPU Performance and Quantization automation moved this from In progress to Reviewer approved Apr 8, 2020
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I will merge this PR when CI passed.

@zixuanweeei
Copy link
Contributor Author

LGTM and I will merge this PR when CI passed.

Maybe we need to wait for #17972. @TaoLv Any comment?

@zixuanweeei
Copy link
Contributor Author

Perhaps we need to upgrade dnnl to its v1.3 release (#17972) at first. #17872 could then be fixed, and backported to MXNet-1.7 with dnnl v1.3. This PR can be finally merged into master. @ciyongch @TaoLv @pengzhao-intel

@pengzhao-intel
Copy link
Contributor

Perhaps we need to upgrade dnnl to its v1.3 release (#17972) at first. #17872 could then be fixed, and backported to MXNet-1.7 with dnnl v1.3. This PR can be finally merged into master. @ciyongch @TaoLv @pengzhao-intel

Got it and will wait for a while.

@zixuanweeei
Copy link
Contributor Author

@mxnet-bot run [unix-gpu]

@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@zixuanweeei
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@pengzhao-intel
Copy link
Contributor

@zixuanweeei please help resolve the conflict :)

* cpp unittest dependency
@zixuanweeei
Copy link
Contributor Author

Please note that mkldnn submodule is pinned to its v1.4-rc version in this PR.

@pengzhao-intel
Copy link
Contributor

Please note that mkldnn submodule is pinned to its v1.4-rc version in this PR.

Thanks for the reminder. I think it's fine with 1.4-rc and we can update to 1.4 later.

@pengzhao-intel pengzhao-intel merged commit 0bff90d into apache:master Apr 12, 2020
CPU Performance and Quantization automation moved this from Reviewer approved to Done Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants