Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DO NOT MERGE] Use mkl cmake flag to force DNNL to delegate FC op to MKL #18338

Closed
wants to merge 3 commits into from

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented May 16, 2020

Description

Currently, for GEMM ops [DNNL delegates that op to MKL]
However, for FC DNNL doesn't.
Workaround : export USE_MKL & pass location of MKL installation.
This forces DNNL to delegate ops to MKL
This PR tries to verify correctness of the workaround [if it breaks any unit-tests]

@leezu @PatricZhao @TaoLv @kpuatamazon @kpu

This PR is not meant to be merged. But to serve as a proxy for internal releases.
If it passes the CI without issues, PR will be closed.
Pipelines to be watched for : windows-cpu, unix-cpu & centos-cpu
Specifically mkldnn/mkl builds.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-gpu, windows-gpu, unix-cpu, unix-gpu, windows-cpu, centos-cpu, website, edge, miscellaneous, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya
Copy link
Contributor Author

Related issue : #17980

@leezu leezu marked this pull request as draft May 16, 2020 00:55
@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci[all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, edge, sanity, windows-gpu, centos-cpu, clang, miscellaneous, unix-cpu, windows-cpu, unix-gpu, website]

@ChaiBapchya
Copy link
Contributor Author

In favor of upcoming fixes due to oneDNN v1.6.1 & v1.7.0 this kludge is no longer required. Details in the linked issue.

@ChaiBapchya ChaiBapchya deleted the use_mkl branch August 18, 2020 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants