Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove six in ci docker #19604

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Remove six in ci docker #19604

merged 2 commits into from
Dec 2, 2020

Conversation

rondogency
Copy link
Contributor

Description

Attempt to fix lint issue in #19603 on master (as @leezu mentioned it also affect mater)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @rondogency , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, unix-cpu, website, centos-gpu, edge, miscellaneous, clang, unix-gpu, windows-cpu, sanity, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 30, 2020
@leezu leezu mentioned this pull request Nov 30, 2020
Open
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 1, 2020
@Zha0q1
Copy link
Contributor

Zha0q1 commented Dec 1, 2020

applied the same changes, seeing the same build failures here https://github.com/apache/incubator-mxnet/pull/19174a

@leezu
Copy link
Contributor

leezu commented Dec 1, 2020

@mxnet-bot run ci [unix-cpu, website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, website]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 1, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 2, 2020
@leezu leezu merged commit 29dd481 into apache:master Dec 2, 2020
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Dec 3, 2020
@samskalicky
try removing six per apache#19604
ec86d38
@kpuatamazon kpuatamazon mentioned this pull request Dec 4, 2020
Merged
6 tasks
samskalicky added a commit that referenced this pull request Dec 4, 2020
@samskalicky
Support destructors for custom stateful ops (#19607)
35cab31 
* initial commit

* added warning message

* added destroy function to call delete in custom library

* try removing six per #19604

* fixed lint

* fixed readability
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Dec 4, 2020
@samskalicky
Support destructors for custom stateful ops (apache#19607)
1487cb9 
* initial commit

* added warning message

* added destroy function to call delete in custom library

* try removing six per apache#19604

* fixed lint

* fixed readability
samskalicky added a commit that referenced this pull request Dec 7, 2020
@samskalicky
Forward port Support destructors for custom stateful ops (#19607) (#1…
4879c7a 
…9632)

* Support destructors for custom stateful ops (#19607)

* initial commit

* added warning message

* added destroy function to call delete in custom library

* try removing six per #19604

* fixed lint

* fixed readability

* fix lint

* fixed lint

* fixed override
@access2rohit access2rohit mentioned this pull request Feb 17, 2021
Closed
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rondogency @mxnet-bot @Zha0q1 @leezu @szha @lanking520