Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DOC] fix warnings in tutorials and turn on -W #19624

Merged
merged 5 commits into from
Dec 8, 2020
Merged

[DOC] fix warnings in tutorials and turn on -W #19624

merged 5 commits into from
Dec 8, 2020

Conversation

szha
Copy link
Member

@szha szha commented Dec 3, 2020

Description

fix warnings in tutorials

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • fix warnings in tutorials and turn on -W

@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, centos-cpu, unix-gpu, sanity, centos-gpu, windows-cpu, miscellaneous, clang, website, unix-cpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2020
@leezu
Copy link
Contributor

leezu commented Dec 3, 2020 

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/symbol.py:docstring of mxnet.contrib.symbol.sldwin_atten_context:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/symbol.py:docstring of mxnet.contrib.symbol.sldwin_atten_context:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/symbol.py:docstring of mxnet.contrib.symbol.sldwin_atten_mask_like:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/symbol.py:docstring of mxnet.contrib.symbol.sldwin_atten_mask_like:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/symbol.py:docstring of mxnet.contrib.symbol.sldwin_atten_score:14: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/ndarray.py:docstring of mxnet.contrib.ndarray.sldwin_atten_context:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/ndarray.py:docstring of mxnet.contrib.ndarray.sldwin_atten_context:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/ndarray.py:docstring of mxnet.contrib.ndarray.sldwin_atten_mask_like:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/ndarray.py:docstring of mxnet.contrib.ndarray.sldwin_atten_mask_like:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/contrib/ndarray.py:docstring of mxnet.contrib.ndarray.sldwin_atten_score:14: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] WARNING: failed to import mxnet.gluon.contrib.rnn

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/image/info_gan.ipynb:363: WARNING: Duplicate substitution definition name: "gif".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/loss/loss.ipynb:431: WARNING: Undefined substitution referenced: "triplet_loss".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/loss/loss.ipynb:441: WARNING: Undefined substitution referenced: "ctc_loss".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/training/normalization/index.ipynb:140: WARNING: Undefined substitution referenced: "normalizatio n nchw bn".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/training/normalization/index.ipynb:140: WARNING: Undefined substitution referenced: "normalizatio n ntc bn".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/training/normalization/index.ipynb:377: WARNING: Undefined substitution referenced: "normalizatio n nchw ln".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/training/normalization/index.ipynb:377: WARNING: Undefined substitution referenced: "normalizatio n ntc ln".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/training/normalization/index.ipynb:454: WARNING: Undefined substitution referenced: "normalizatio n nchw in".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/packages/gluon/training/normalization/index.ipynb:454: WARNING: Undefined substitution referenced: "normalizatio n ntc in".

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/getting-started/to-mxnet/pytorch.ipynb:645: WARNING: Inline literal start-string without end-string.

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/getting-started/to-mxnet/pytorch.ipynb:655: WARNING: Inline literal start-string without end-string.

[2020-12-03T20:31:38.575Z] /work/mxnet/docs/python_docs/python/build/tutorials/getting-started/to-mxnet/pytorch.ipynb:725: WARNING: Inline literal start-string without end-string.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/symbol/contrib.py:docstring of mxnet.symbol.contrib.sldwin_atten_context:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/symbol/contrib.py:docstring of mxnet.symbol.contrib.sldwin_atten_context:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/symbol/contrib.py:docstring of mxnet.symbol.contrib.sldwin_atten_mask_like:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/symbol/contrib.py:docstring of mxnet.symbol.contrib.sldwin_atten_mask_like:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/symbol/contrib.py:docstring of mxnet.symbol.contrib.sldwin_atten_score:14: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/ndarray/contrib.py:docstring of mxnet.ndarray.contrib.sldwin_atten_context:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/ndarray/contrib.py:docstring of mxnet.ndarray.contrib.sldwin_atten_context:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/ndarray/contrib.py:docstring of mxnet.ndarray.contrib.sldwin_atten_mask_like:9: WARNING: Unexpected indentation.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/ndarray/contrib.py:docstring of mxnet.ndarray.contrib.sldwin_atten_mask_like:10: WARNING: Block quote ends without a blank line; unexpected unindent.

[2020-12-03T20:31:38.575Z] /work/mxnet/python/mxnet/ndarray/contrib.py:docstring of mxnet.ndarray.contrib.sldwin_atten_score:14: WARNING: Unexpected indentation.

@szha
Copy link
Member Author

szha commented Dec 4, 2020

yeah I missed them due to unclean build. I'm working on them

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 4, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 4, 2020
@szha szha requested a review from marcoabreu as a code owner December 4, 2020 21:40
@lanking520 lanking520 removed the pr-work-in-progress PR is still work in progress label Dec 4, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 5, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 8, 2020
@leezu
Copy link
Contributor

leezu commented Dec 8, 2020

@mxnet-bot run ci [unix-gpu, centos-gpu, website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-gpu, website]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 8, 2020
@szha
Copy link
Member Author

szha commented Dec 8, 2020

finally green

@leezu leezu merged commit 6cbd3ae into apache:master Dec 8, 2020
@leezu leezu deleted the tutorial_warnings branch December 8, 2020 16:13
@leezu leezu mentioned this pull request Jan 28, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szha @mxnet-bot @leezu @lanking520