Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add more ONNX export support to operators #19625

Merged
merged 22 commits into from Dec 11, 2020
Merged

[v1.x] Add more ONNX export support to operators #19625

merged 22 commits into from Dec 11, 2020

Conversation

josephevans
Copy link
Contributor

Description

Implements ONNX export for the following operators:

  • gelu (leakyrelu with act_type = 'gelu')
  • LayerNorm
  • Embedding
  • Stack
  • arange_like
  • zeros_like

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, unix-cpu, website, edge, unix-gpu, centos-gpu, centos-cpu, miscellaneous, windows-gpu, windows-cpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Dec 8, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 8, 2020
Zha0q1
Zha0q1 approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 removed the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 8, 2020
@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Dec 11, 2020
Joe Evans added 22 commits December 10, 2020 21:56
Add helper function to create tensors from scalar values that can be …
bf048d2 
…used as inputs to onnx ops.
Add ONNX export support for leakyrelu op with act_type = 'gelu'.
87901ee
Add ONNX export support for LayerNorm operator.
469d9ac
Add ONNX export support for Embedding and stack operators.
38a679e
Add helper function to create constant tensor from array, add ONNX ex…
78b1017 
…port support for slice operator.
Add comment.
178bdd7
Add WIP for arange_like and zeros_like.
e77cada
Remove incomplete conversion function for arange_like.
ce06c06
Fix lint.
7e1d98c
Fix lint.
61503e0
Add arange_like onnx export function.
562aef6
Use shape from input for create_const_node(), fix a few operators.
7055bf2
Add tests for onnx operator conversion.
45ec5ca
Fix lint.
b6a9c8b
Add test for arange_like export and make sure arange_like export uses…
f740c43 
… same datatype as input.
Clean up code.
dda301c
Update to work with ops with arguments.
50c6c87
Use the correct data iinput for LayerNorm export.
115ed4a
Add test for LayerNorm export, remove debug print statements.
6ba6edc
Run onnx/test_operators.py unit tests in onnx test suite.
24c3f70
Clean up operator exports, change string formats that work with pytho…
8c09a60 
…n 3.5.
Pytest version in 1.x branch doesn't support tmp_path, so do it insid…
a86dec3 
…e the tests.
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 11, 2020
@Zha0q1 Zha0q1 merged commit b219ac2 into apache:v1.x Dec 11, 2020
@josephevans josephevans deleted the onnx_bert_support_v1.x branch December 11, 2020 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephevans @mxnet-bot @Zha0q1 @lanking520