Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Onnx fix slice_axis and embedding and reshape #19677

Merged
merged 9 commits into from Dec 17, 2020
Merged

[v1.x] Onnx fix slice_axis and embedding and reshape #19677

merged 9 commits into from Dec 17, 2020

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Dec 15, 2020 •
edited

fixed:

  1. slice_axis
  2. reshape
  3. embedding

added/tweaked tests for

  1. embedding
  2. slice_axis
  3. reshape
  4. contrib_interleaved_matmul_selfatt_qk

@Zha0q1 Zha0q1 requested a review from szha as a code owner December 15, 2020 21:10
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-gpu, centos-cpu, unix-cpu, miscellaneous, website, windows-cpu, unix-gpu, windows-gpu, edge, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 15, 2020
@Zha0q1 Zha0q1 mentioned this pull request Dec 15, 2020
Merged
4 tasks
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
@Zha0q1 Zha0q1 changed the title [v1.x] Onnx fix slice_axis and reshape [v1.x] Onnx fix slice_axis and embedding fix Dec 16, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 16, 2020
josephevans
josephevans approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

waytrue17
waytrue17 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 16, 2020
@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Dec 16, 2020
@Zha0q1 Zha0q1 changed the title [v1.x] Onnx fix slice_axis and embedding fix [v1.x] Onnx fix slice_axis and embedding and reshape Dec 16, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Dec 16, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 17, 2020
waytrue17
waytrue17 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 17, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 17, 2020
josephevans
josephevans approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zha0q1 Zha0q1 merged commit c53e32b into apache:v1.x Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@waytrue17 waytrue17 waytrue17 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Zha0q1 @mxnet-bot @josephevans @waytrue17 @lanking520