This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] Fix nightly CD for python docker image releases #19774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mseth10 , Thanks for submitting the PR
CI supported jobs: [windows-gpu, website, centos-cpu, edge, unix-gpu, sanity, windows-cpu, unix-cpu, miscellaneous, centos-gpu, clang] Note: |
lanking520
added
the
pr-awaiting-testing
szha
approved these changes
Jan 22, 2021
lanking520
added
pr-awaiting-merge
leezu
reviewed
Jan 22, 2021
|
we could also consider publishing nightly tags to ECR and make them available to only developers. |
mseth10
force-pushed
the
update_nightly_docker_tag
branch
2 times, most recently
from
3249e55
to
ec67ada
Compare
lanking520
added
pr-awaiting-testing
mseth10
changed the title
lanking520
added
pr-awaiting-review
mseth10
force-pushed
the
update_nightly_docker_tag
branch
from
ec67ada
to
d29c96b
Compare
lanking520
added
pr-awaiting-testing
mseth10
force-pushed
the
update_nightly_docker_tag
branch
from
d29c96b
to
f04ec20
Compare
lanking520
added
pr-awaiting-testing
* install wget * test cd docker in ci * install docker * install python3-dev and gcc * remove docker testing from ci * remove python3-dev * ecr target * skip build test * adding back python3-dev for make * remove dynamic and pypi stages for testing * install build-essential * install zlib * update python version * update ld library path * install openssl * update test packages for python3.7 * remove call to deleted safe_docker_run.py * hardcode region for public ecr repo * use deadsnakes to install python * revert dependency change * refactor ecr login * update ecr repo jenkins global var * cleanup * update docker authentication * add ecr repo * add back pypi and tests * remove unused libmxnet pipeline * update cu112 base docker * update base docker images to ub18
mseth10
force-pushed
the
update_nightly_docker_tag
branch
from
f04ec20
to
fdc789d
Compare
lanking520
added
pr-awaiting-review
lanking520
added
pr-work-in-progress
waytrue17
approved these changes
Mar 2, 2021
| // artifact (docker image, binary, pypi or maven package, etc.) that should | ||
| // be published. | ||
|
|
||
| STATE_UPDATE="State Update" | ||
|
|
||
| def trigger_release_job(job_name, job_type, mxnet_variants) { | ||
| def trigger_release_job(cd_release_job, job_name, job_type, mxnet_variants) { |
There was a problem hiding this comment.
Curious, why do we pass the cd_release_job instead of using the env var?
There was a problem hiding this comment.
CD_RELEASE_JOB_NAME is actually a parameter of the CD pipeline, so this is how it's supposed to be used. It is also set as a global env variable, which can potentially cause some issues.
For reference, it is addressed in master by this PR #17775
mseth10
added a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Mar 5, 2021
* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775) * Fix nightly CD for python docker image releases (apache#19772) * install wget * test cd docker in ci * install docker * install python3-dev and gcc * remove docker testing from ci * remove python3-dev * ecr target * skip build test * adding back python3-dev for make * remove dynamic and pypi stages for testing * install build-essential * install zlib * update python version * update ld library path * install openssl * update test packages for python3.7 * remove call to deleted safe_docker_run.py * hardcode region for public ecr repo * use deadsnakes to install python * revert dependency change * refactor ecr login * update ecr repo jenkins global var * cleanup * update docker authentication * add ecr repo * add back pypi and tests * remove unused libmxnet pipeline * update cu112 base docker * update base docker images to ub18 * differentiate tag prefix for v1.x Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
mseth10
added a commit
that referenced
this pull request
Mar 8, 2021
… pipeline (#19989) * [v1.x] Fix nightly CD for python docker image releases (#19774) * [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775) * Fix nightly CD for python docker image releases (#19772) * install wget * test cd docker in ci * install docker * install python3-dev and gcc * remove docker testing from ci * remove python3-dev * ecr target * skip build test * adding back python3-dev for make * remove dynamic and pypi stages for testing * install build-essential * install zlib * update python version * update ld library path * install openssl * update test packages for python3.7 * remove call to deleted safe_docker_run.py * hardcode region for public ecr repo * use deadsnakes to install python * revert dependency change * refactor ecr login * update ecr repo jenkins global var * cleanup * update docker authentication * add ecr repo * add back pypi and tests * remove unused libmxnet pipeline * update cu112 base docker * update base docker images to ub18 * differentiate tag prefix for v1.x Co-authored-by: Sheng Zha <szha@users.noreply.github.com> * pass version param (#19982) * remove cu112 changes Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
mseth10
added a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Mar 15, 2021
… pipeline (apache#19989) * [v1.x] Fix nightly CD for python docker image releases (apache#19774) * [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775) * Fix nightly CD for python docker image releases (apache#19772) * install wget * test cd docker in ci * install docker * install python3-dev and gcc * remove docker testing from ci * remove python3-dev * ecr target * skip build test * adding back python3-dev for make * remove dynamic and pypi stages for testing * install build-essential * install zlib * update python version * update ld library path * install openssl * update test packages for python3.7 * remove call to deleted safe_docker_run.py * hardcode region for public ecr repo * use deadsnakes to install python * revert dependency change * refactor ecr login * update ecr repo jenkins global var * cleanup * update docker authentication * add ecr repo * add back pypi and tests * remove unused libmxnet pipeline * update cu112 base docker * update base docker images to ub18 * differentiate tag prefix for v1.x Co-authored-by: Sheng Zha <szha@users.noreply.github.com> * pass version param (apache#19982) * remove cu112 changes Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes multiple changes to fix the nightly CD pipeline for python docker image releases.