Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix precision vars initialization in TRT #20277

Merged
merged 1 commit into from May 20, 2021
Merged

Conversation

Kh4L
Copy link
Contributor

@Kh4L Kh4L commented May 18, 2021

Description

Fix precision vars initialization in TRT

Signed-off-by: Serge Panev <spanev@nvidia.com>
@mxnet-bot
Copy link

Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, centos-gpu, unix-cpu, centos-cpu, miscellaneous, unix-gpu, windows-cpu, windows-gpu, edge, website, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 18, 2021
@DickJC123 DickJC123 self-requested a review May 20, 2021 04:48
Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, one needs to remember that data members like fp16_mode_ and int8_mode_ are not initialized by default. I see that calibration_iters_ is initted only when needed (i.e. when int8_mode_ is true). LGTM.

@DickJC123 DickJC123 merged commit d6a0880 into apache:v1.x May 20, 2021
samskalicky pushed a commit that referenced this pull request May 21, 2021
Signed-off-by: Serge Panev <spanev@nvidia.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants