Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch, #19945 from master #20785

Merged
merged 5 commits into from
Dec 22, 2021

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Dec 20, 2021

Backport CD/CI fixes from v1.9.x and master branches into v1.x branch.

* Change env variable used to detect whether it's a release build or not. RELEASE_BUILD is already setup in the CD pipeline.

* Refine how variable is compared to trigger release builds.

* Check for 'true' exclusively, to prevent unwanted release builds.

* Make sure we pass any environment variables on the build.py command line to the docker run command.
* Add wheel to installed pip packages on aarch64, so we can build the wheel in the CD pipeline.

* Better support for aarch64 docker container cache.

* Only import machine() function from platform module, as platform variable is already widely used.

* Only build containers with aarch64 in name on aarch64.

* Make all arch defaults to local machine type.
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, unix-cpu, windows-cpu, website, clang, unix-gpu, sanity, windows-gpu, centos-gpu, centos-cpu, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 20, 2021
…onnect timeout from 10 to 60sec, increase retry delay from 0 (setting duplicated) to 30, increase retry attempts to 5.
@josephevans josephevans changed the title [v1.x] Backport #20782 and #20783 from v1.9.x branch [v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch Dec 21, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 21, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 21, 2021
* fix website

* fix header

* fix index

* remove locall test

* fix main.scss

Co-authored-by: Wei Chu <weichu@amazon.com>
@mseth10 mseth10 removed the pr-awaiting-review PR is waiting for code review label Dec 21, 2021
@josephevans josephevans changed the title [v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch [v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch, #19945 from master Dec 21, 2021
@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 21, 2021
@waytrue17 waytrue17 mentioned this pull request Dec 21, 2021
6 tasks
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 22, 2021
@josephevans josephevans merged commit b5e8bf6 into apache:v1.x Dec 22, 2021
@josephevans josephevans deleted the v1.x_backport_cd_fixes branch December 22, 2021 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants