DType regression #3018
DType regression #3018
Conversation
Godricly
commented
Aug 13, 2016
Godricly
commented
- DType regression
- Python test for DType pooling and regression
| Tensor<xpu, 2, DType> grad = in_grad[reg_enum::kData].FlatTo2D<xpu, DType>(s); | ||
| Tensor<xpu, 2, DType> label = in_data[reg_enum::kLabel] | ||
| .get_with_shape<xpu, 2, DType>(out.shape_, s); | ||
| Assign(grad, req[reg_enum::kData], scalar<DType>(param_.grad_scale/num_output)* |
There was a problem hiding this comment.
Is this correct? What if Dtype is int8?
There was a problem hiding this comment.
Thank you for your review. Which line are you worry about? I think int8 is currently not supported as we are using MSHADOW_REAL_TYPE_SWITCH to create operators.
There was a problem hiding this comment.
OK, merge as is for now. We have to change a lot for the coming unit8...
There was a problem hiding this comment.
yep... I'll propose a pr to fix nullptr issue in other operators later. Is there any paper list to share about uint8 network?
There are some other issues to be fixed to make DType network really works, like kvstore, param init. For the lstm case, extra states data_type is need. We need to discuss more about this DType support and a more detail todo list.
|
Some inline comments are added. After fixing them, it is good to merge in |
|
Please update to latest master, so that I can merge |
|
Cpp test failed after the update. |
|
@Godricly We have to revert this PR until you provide correct test scripts and corresponding results. |
|
Sry for that typo. I don't have GPU access now, so a fix will take some time. The operator should be ok. Does that script get called in travis? |
