This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Allocating largest arrays first in GraphExecutor in order to save space. #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eric-haibin-lin I think this is the same with the sorting method we talked about? |
|
yes it's the same method
On 2017年2月27日, at 11:37, Eric Junyuan Xie <notifications@github.com> wrote:
@eric-haibin-lin I think this is the same with the sorting method we talked about?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change ndarrays were just allocated in the order they are in the graph. This could lead to scenarios where large ndarrays from the shared pool get used for relatively small ndarrays. Trying to allocate the largest ndarrays from the shared pool first will avoid this and save space. #5035